Only really run pre-script when it is set

sabnzbd/filesystem.py

@@ -457,17 +457,17 @@ def fix_unix_encoding(folder):
 
 def make_script_path(script):
     """ Return full script path, if any valid script exists, else None """
-    s_path = None
+    script_path = None
-    path = sabnzbd.cfg.script_dir.get_path()
+    script_dir = sabnzbd.cfg.script_dir.get_path()
-    if path and script:
+    if script_dir and script:
         if script.lower() not in ("none", "default"):
-            s_path = os.path.join(path, script)
+            script_path = os.path.join(script_dir, script)
-            if not os.path.exists(s_path):
+            if not os.path.exists(script_path):
-                s_path = None
+                script_path = None
             else:
                 # Paths to scripts should not be long-path notation
-                s_path = clip_path(s_path)
+                script_path = clip_path(script_path)
-    return s_path
+    return script_path
 
 
 def get_admin_path(name, future):

sabnzbd/nzbstuff.py

@@ -78,6 +78,7 @@ from sabnzbd.filesystem import (
     remove_file,
     get_filepath,
     globber,
+    make_script_path,
 )
 from sabnzbd.decorators import synchronized
 import sabnzbd.config as config
@@ -789,8 +790,8 @@ class NzbObject(TryList):
         self.set_priority(priority)
         self.repair, self.unpack, self.delete = pp_to_opts(pp_tmp)
 
-        # Run user pre-queue script if needed
+        # Run user pre-queue script if set and valid
-        if not reuse and cfg.pre_script():
+        if not reuse and make_script_path(cfg.pre_script()):
             # Call the script
             accept, name, pp, cat_pp, script_pp, priority, group = sabnzbd.newsunpack.pre_queue(self, pp, cat)